[LTP] [PATCH v1 2/2] security/dirtyc0w_shmem: Drop useless needs_tmpdir tag

Martin Doucha mdoucha@suse.cz
Fri Nov 25 14:32:42 CET 2022


Hi,
both patches look good.

Reviewed-by: Martin Doucha <mdoucha@suse.cz>

On 25. 11. 22 13:31, David Hildenbrand wrote:
> Compilation points out that:
>    testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c: useless tag:
>    needs_tmpdir
> 
> needs_tmpdir is implied by needs_checkpoints, so we can drop it.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>   testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> index 1e3b194e7..14b8f8317 100644
> --- a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> +++ b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> @@ -109,7 +109,6 @@ static struct tst_test test = {
>   	.needs_checkpoints = 1,
>   	.forks_child = 1,
>   	.needs_root = 1,
> -	.needs_tmpdir = 1,
>   	.max_runtime = 120,
>   	.setup = setup,
>   	.cleanup = cleanup,

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic



More information about the ltp mailing list