[LTP] [PATCH] mkfs: relax size check

Petr Vorel pvorel@suse.cz
Wed Nov 30 09:06:39 CET 2022


Hi all,

> Hi zenghongling,

> > Number of total data blocks in filesystem reported by statfs
> > may be less than current formula of 90%. For example ext4 will
> > subtract "s_first_data_block plus internal journal blocks".

> > With recent change to e2fsprogs, overhead calculated in user-space increased
> Do you know in which version it got changed?

For a record, zenghongling send html mail
https://lore.kernel.org/ltp/2oc1dehrobv-2oc577y0tt8@nsmail7.0.0--kylin--1/T/#u

thus repeat it here: the affected commit is here:
https://github.com/tytso/e2fsprogs/commit/59037c5357d39c6d0f14a0aff70e67dc13eafc84
which is from v1.46.0.

I'm testing it on openSUSE with 1.46.5 and it does not have problem.
Maybe there is some problem on the system you test and lower the barrier you
just hide it. Maybe others see it differently.

> Maybe it'd be worth to mention that to ext4 maintainers,
> just to be sure it's not a regression.

> > slightly and LTP test started failing: tytso/e2fsprogs
> A bit cryptic description :(. You mean probably https://github.com/tytso/e2fsprogs
> which is also on
> https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/

@zenghongling basic mailing list rules
1) sent text/plain (not text/html), otherwise mail is not readable
https://lore.kernel.org/ltp/2oc1dehrobv-2oc577y0tt8@nsmail7.0.0--kylin--1/T/#u
and not even in patchwork:
https://patchwork.ozlabs.org/project/ltp/patch/1669691831-23456-1-git-send-email-zenghongling@kylinos.cn/

Compare with my mail:
https://lore.kernel.org/ltp/Y4Xd4jd%2FX5zsmoqH@pevik/T/#m76d4ae3f396a6ae63382cb569c33d8c746ce0974

More instructions are:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text

2) reply to mail thread so that mail is connected to the thread
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#explicit-in-reply-to-headers

Actually most of the reading for kernel applies to LTP as well
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Kind regards,
Petr


More information about the ltp mailing list