[LTP] [PATCH v3 0/9] mmapstress01: refactor to ltp framework
Cyril Hrubis
chrubis@suse.cz
Wed Oct 5 12:31:13 CEST 2022
Hi!
The code is heading into the right direction but there are couple of
things to do (can be done in an incremental manner too):
* Most of the remaning tst_brk(TFAIL, "..") should actually be
tst_brk(TBROK, "..") at least all the cases where we call
a syscall and it fails. And we should include the TERRNO flag
as well to get the actual error printed.
* The test should make use of runtime instead of the alarm()
for test duration. That would mean getting rid of the -t option and
using the -I option instead. Also the test should set up some
.test_runtime for a default run duration in the tst_test structure.
* The top level comment has to be updated for the changes in the test
since the options structure describes the command line parameters
quite well I would just remove that part from the comment
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list