[LTP] [PATCH v4 3/3] syscalls/openat: Add new regression test when using open(O_TMPFILE) under umask

[xuyang2018.jy@fujitsu.com]

Hi Cyril

> Hi Christian
> 
>> On Thu, Sep 22, 2022 at 11:27:43AM +0200, Cyril Hrubis wrote:
>>> Hi!
>>>>> And this one is probably missing some kernel commit tags too, since the only that that is attached is supposedly in 5.19 but the test still fails.
>>>>
>>>>> I supposed that we should add the 426b4ca2d6a5 to the test tags here as well, right?
>>>>
>>>> Yes, BTW,  I usually use git tag --contains command, so I know this kernel fix is belong to 6.0.
>>>>
>>>> git tag --contains ac6800e27
>>>> v6.0-rc1
>>>> v6.0-rc2
>>>
>>> Now I'm confused, if I do git describe ac6800e27 it says that it's a
>>> second commit on the top of 5.19-rc7. So shouldn't the the git tag
>>> --contains report 5.19-rc8 and newer? What do I miss?
>>
>> So, ac6800e279a2 ("fs: Add missing umask strip in vfs_tmpfile") has been
>> backported to kernels since before the dawn of time. But the the all the
>> pieces that move setgid handling out of individual filesystems and into
>> the vfs proper are only >= v6.0-rc1.
> 
> I search the commit mesage in the following url,but not find c6800e279a2
> commit
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h=v5.19
> 
> @Cyril
> I guess git describe ac6800e2 will serach the commit id because it is
> merge request"Merge tag 'fs.setgid.v6.0' of
> git://git.kernel.org/pub/scm/linux/kerne/git/brauner/linux"
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=426b4ca2d6a5
> 
> then it will serach brauner linux fs.setgid. branch
> see the following url
> https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=fs.setgid
> 
> so git describe ac6800e27 it says that it's a second commit on the top
> of 5.19-rc7.

So do you still have doubt on this?  I don't think this should block 
this two patches.

Best Regards
Yang Xu
> 
> 
> Best Regards
> Yang Xu
>