[LTP] [PATCH 2/2] needs_root: Add setting of needs_root

Petr Vorel pvorel@suse.cz
Thu Oct 13 11:19:06 CEST 2022


> Hi Petr,

> It is failed on my system:

> sh-4.4$ ./msgget03
> tst_test.c:1535: TINFO: Timeout per run is 0h 00m 30s
> msgget03.c:42: TINFO: Current environment 0 message queues are already in use
> msgget03.c:45: TBROK: Failed to open FILE '/proc/sys/kernel/msgmni' for writing: EACCES (13)

Ah, b740bfac5 ("msgget03: Set custom queue limit")
causes the need for root. IMHO this one is valid.

I'd suggest to remove needs_root for needs_device and mount_device now
(i.e. send v2).

nit: FYI most of the people use bottom posting on mailing lists, you use top
posting. Combine both makes it hard to follow.

https://en.wikipedia.org/wiki/Posting_style

Kind regards,
Petr


> Summary:
> passed   0
> failed   0
> broken   1
> skipped  0
> warnings 0
> tst_sys_conf.c:118: TWARN: Failed to open FILE '/proc/sys/kernel/msgmni'


More information about the ltp mailing list