[LTP] [PATCH 15/29] Hugetlb: Migrating libhugetlbfs misalign
Tarun Sahu
tsahu@linux.ibm.com
Sun Oct 16 14:57:17 CEST 2022
Migrating the libhugetlbfs/testcases/misalign.c test
Test Description: Just as normal mmap()s can't have an address, length or
offset which is not page aligned, so hugepage mmap()s can't have an
address, length or offset with is not hugepage aligned.
However, from time to time when the various mmap() /
get_unmapped_area() paths are updated, somebody misses one of the
necessary checks for the hugepage paths. This testcase ensures
that attempted hugepage mappings with parameters which are not
correctly hugepage aligned are rejected.
However starting with 3.10-rc1, length passed in mmap() doesn't need
to be aligned because 'commit af73e4d9506d3b797509f3c030e7dcd554f7d9c4
("hugetlbfs: fix mmap failure in unaligned size request")' added ALIGN()
to kernel side, in mmap_pgoff(), when mapping huge page files.
Signed-off-by: Tarun Sahu <tsahu@linux.ibm.com>
---
runtest/hugetlb | 1 +
testcases/kernel/mem/.gitignore | 1 +
.../kernel/mem/hugetlb/hugemmap/hugemmap18.c | 173 ++++++++++++++++++
3 files changed, 175 insertions(+)
create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap18.c
diff --git a/runtest/hugetlb b/runtest/hugetlb
index 5fac3481c..de76cdaf2 100644
--- a/runtest/hugetlb
+++ b/runtest/hugetlb
@@ -19,6 +19,7 @@ hugemmap14 hugemmap14
hugemmap15 hugemmap15
hugemmap16 hugemmap16
hugemmap17 hugemmap17
+hugemmap18 hugemmap18
hugemmap05_1 hugemmap05 -m
hugemmap05_2 hugemmap05 -s
hugemmap05_3 hugemmap05 -s -m
diff --git a/testcases/kernel/mem/.gitignore b/testcases/kernel/mem/.gitignore
index 6aa54f902..daee70586 100644
--- a/testcases/kernel/mem/.gitignore
+++ b/testcases/kernel/mem/.gitignore
@@ -18,6 +18,7 @@
/hugetlb/hugemmap/hugemmap15
/hugetlb/hugemmap/hugemmap16
/hugetlb/hugemmap/hugemmap17
+/hugetlb/hugemmap/hugemmap18
/hugetlb/hugeshmat/hugeshmat01
/hugetlb/hugeshmat/hugeshmat02
/hugetlb/hugeshmat/hugeshmat03
diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap18.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap18.c
new file mode 100644
index 000000000..bd3593570
--- /dev/null
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap18.c
@@ -0,0 +1,173 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
+/*
+ * Copyright (C) 2005-2007 David Gibson & Adam Litke, IBM Corporation.
+ *
+ * Test Name: Misalign
+ *
+ * Test Description: Just as normal mmap()s can't have an address, length or
+ * offset which is not page aligned, so hugepage mmap()s can't have an
+ * address, length or offset with is not hugepage aligned.
+ *
+ * However, from time to time when the various mmap() /
+ * get_unmapped_area() paths are updated, somebody misses one of the
+ * necessary checks for the hugepage paths. This testcase ensures
+ * that attempted hugepage mappings with parameters which are not
+ * correctly hugepage aligned are rejected.
+ *
+ * However starting with 3.10-rc1, length passed in mmap() doesn't need
+ * to be aligned because commit af73e4d9506d3b797509f3c030e7dcd554f7d9c4
+ * added ALIGN() to kernel side, in mmap_pgoff(), when mapping huge page
+ * files.
+ *
+ * HISTORY
+ * Written by David Gibson & Adam Litke
+ *
+ */
+
+#define _GNU_SOURCE
+#include <stdio.h>
+#include <sys/mount.h>
+#include <limits.h>
+#include <sys/param.h>
+#include <sys/types.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+#include <errno.h>
+#include <signal.h>
+#include <sys/mman.h>
+#include <sys/utsname.h>
+
+#include "hugetlb.h"
+
+static char *verbose;
+static long hpage_size;
+static int fd = -1;
+static char hfile[MAXPATHLEN];
+
+static void run_test(void)
+{
+ long page_size;
+ void *p, *q;
+
+ fd = SAFE_OPEN(hfile, O_RDWR | O_CREAT, 0600);
+ SAFE_UNLINK(hfile);
+
+ page_size = getpagesize();
+
+ /* First see what an ok mapping looks like, as a basis for our
+ * bad addresses and so forth
+ */
+ p = mmap(NULL, hpage_size, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0);
+ if (p == MAP_FAILED) {
+ tst_res(TFAIL|TERRNO, "mmap() without hint failed");
+ goto fail;
+ }
+ if (((unsigned long)p % hpage_size) != 0) {
+ tst_res(TFAIL, "mmap() without hint at misaligned address");
+ goto fail;
+ }
+
+ if (verbose)
+ tst_res(TINFO, "Mapped at %p, length 0x%lx\n", p, hpage_size);
+
+ SAFE_MUNMAP(p, hpage_size);
+
+ /* 1) Try a misaligned hint address */
+ q = mmap(p + page_size, hpage_size, PROT_READ|PROT_WRITE,
+ MAP_PRIVATE, fd, 0);
+ if (q == MAP_FAILED) {
+ /* Bad hint shouldn't fail, just ignore the hint */
+ tst_res(TFAIL|TERRNO, "mmap() with hint failed");
+ goto fail;
+ }
+ if (((unsigned long)q % hpage_size) != 0) {
+ tst_res(TFAIL, "mmap() with hint at misaligned address");
+ goto fail;
+ }
+
+ SAFE_MUNMAP(q, hpage_size);
+
+ /* 2) Try a misaligned address with MAP_FIXED */
+ q = mmap(p + page_size, hpage_size, PROT_READ|PROT_WRITE,
+ MAP_PRIVATE|MAP_FIXED, fd, 0);
+ if (q != MAP_FAILED) {
+ tst_res(TFAIL, "mmap() MAP_FIXED at misaligned address succeeded");
+ goto fail;
+ }
+
+ /* 3) Try a misaligned length */
+ q = mmap(NULL, page_size, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0);
+ if (q == MAP_FAILED) {
+ tst_res(TFAIL, "mmap() with misaligned length 0x%lx failed",
+ page_size);
+ goto fail;
+ }
+
+ /* 4) Try a misaligned length with MAP_FIXED */
+ q = mmap(p, page_size, PROT_READ|PROT_WRITE,
+ MAP_PRIVATE|MAP_FIXED, fd, 0);
+ if (q == MAP_FAILED) {
+ tst_res(TFAIL, "mmap() MAP_FIXED with misaligned length 0x%lx "
+ "failed", page_size);
+ }
+
+ /* 5) Try a misaligned offset */
+ q = mmap(NULL, hpage_size, PROT_READ|PROT_WRITE,
+ MAP_PRIVATE, fd, page_size);
+ if (q != MAP_FAILED) {
+ tst_res(TFAIL, "mmap() with misaligned offset 0x%lx succeeded",
+ page_size);
+ goto fail;
+ }
+
+ /* 6) Try a misaligned offset with MAP_FIXED*/
+ q = mmap(p, hpage_size, PROT_READ|PROT_WRITE,
+ MAP_PRIVATE|MAP_FIXED, fd, page_size);
+ if (q != MAP_FAILED) {
+ tst_res(TFAIL, "mmap() MAP_FIXED with misaligned offset 0x%lx succeeded",
+ page_size);
+ goto fail;
+ }
+
+ tst_res(TPASS, "Successful");
+ SAFE_CLOSE(fd);
+ return;
+fail:
+ tst_brk(TBROK, "Once failed, No point in continuing to next iteration");
+}
+
+static void setup(void)
+{
+ if (tst_hugepages < 4)
+ tst_brk(TCONF, "Not enough hugepages for testing.");
+
+ if (!Hopt)
+ Hopt = tst_get_tmpdir();
+ SAFE_MOUNT("none", Hopt, "hugetlbfs", 0, NULL);
+
+ snprintf(hfile, sizeof(hfile), "%s/ltp_hugetlbfile%d", Hopt, getpid());
+ hpage_size = SAFE_READ_MEMINFO("Hugepagesize:")*1024;
+}
+
+static void cleanup(void)
+{
+ if (fd >= 0)
+ SAFE_CLOSE(fd);
+ umount2(Hopt, MNT_DETACH);
+}
+
+static struct tst_test test = {
+ .needs_root = 1,
+ .needs_tmpdir = 1,
+ .options = (struct tst_option[]) {
+ {"v", &verbose, "run"},
+ {"H:", &Hopt, "Location of hugetlbfs, i.e. -H /var/hugetlbfs"},
+ {"s:", &nr_opt, "Set the number of the been allocated hugepages"},
+ {}
+ },
+ .setup = setup,
+ .cleanup = cleanup,
+ .test_all = run_test,
+ .hugepages = {4, TST_REQUEST},
+};
--
2.31.1
More information about the ltp
mailing list