[LTP] [PATCH v2 2/3] Add fanotify_get_supported_init_flags() helper function
Martin Doucha
mdoucha@suse.cz
Fri Oct 21 15:49:58 CEST 2022
On 20. 10. 22 17:36, Amir Goldstein wrote:
> NACK
> this is not the only dependency
> this is not a valid generic function.
>
> I only gave a recipe in v1 review how I think the checks should be done.
I still want to make something that is easy to reuse in other fanotify
tests. It doesn't have to be fully generic. If you want, I can add a
list of manually validated init flags into the support check function
and make the function terminate the program when somebody passes flags
that haven't been validated. That'll ensure that the flag dependency
list will be kept up to date.
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
More information about the ltp
mailing list