[LTP] [PATCH 01/29] Hugetlb: Migrating libhugetlbfs brk_near_huge

Cyril Hrubis chrubis@suse.cz
Wed Oct 26 14:44:42 CEST 2022


Hi!
> Hopt is supposed to be the location which test will use to mount/umount
> the hugetlbfs fs. If Hopt is not provided, it will create a temp
> location. It is only to avoid creating any temporary locations outside
> user concerned test environment.
> 
>      if(!Hopt)
> 	Hopt = tst_get_tmpdir();
>      SAFE_MOUNT("none", Hopt, "hugetlbfs", 0, NULL);
> 
> It is not expecting any already mounted hugetlbfs.

Ah right, this has been changed long ago in:

    7420ed0 hugemmap04: auto mount the temporary dir for testing
    c4dd870 hugemmap03: auto mount the temporary dir for testing
    9b4865f hugemmap02: auto mount the temporary dir for testing
    d8728dc hugemmap01: auto mount the temporary dir for testing

Before that the path had to point to already mounted hugetlbfs. At this
point this option is useless. So I would not add it to new tests at all
and just use the tmpdir unconditionally.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list