[LTP] [PATCH v3 01/10] tst_test.sh: Fix tst_mkfs() for tmpfs

Petr Vorel pvorel@suse.cz
Fri Sep 2 12:22:25 CEST 2022


> Petr Vorel <pvorel@suse.cz> writes:

> > Hi Richie,

> >> Hello,

> >> No response and seems reasonable, please merge!

> >> Acked-by: Richard Palethorpe <rpalethorpe@suse.com>
> > Thanks a lot for your review! I suppose you mean your ack for whole patchset.

> > If yes, I'll merge all but the last RFC commit which needs more work (i.e.
> > TST_ALL_FILESYSTEMS infrastructure although nothing uses it yet).

> > Merging would help me not having to rebase this work after finishing and get
> > merged "Track minimal size per filesystem" [1] (originally I thought that one
> > would go first, but TST_ALL_FILESYSTEMS infrastructure is ready now).

> > I also plan to convert df01.sh and mkfs01.sh to TST_ALL_FILESYSTEMS.

> > Kind regards,
> > Petr

> > [1] https://patchwork.ozlabs.org/project/ltp/list/?series=315621

> OK, I have acked everything that didn't already have a review tag. It
> would help to include some test conversions in the patch set, but I
> trust you will follow up with df01.sh and mkfs01.sh ;-)

Thanks! As I found that there is tiny issue in TST_ALL_FILESYSTEMS
implementation (there should be equivalent of tst_device->fs_type)
I've merged patches up to "[v3,04/10] tst_mount_device.sh: Cover early
tst_umount call" and send v4 with fixed this version and converted at least one
of df01.sh and mkfs01.sh. Then I base "Track minimal size per filesystem"
patchset on this work (suppose this patchet will be quickly re-reviewed).

Kind regards,
Petr


More information about the ltp mailing list