[LTP] [PATCH 1/9] syscalls/fanotify09: Add test cases for FAN_MARK_IGNORE

Petr Vorel pvorel@suse.cz
Mon Sep 5 18:04:41 CEST 2022


Hi Amir,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

...
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify09.c b/testcases/kernel/syscalls/fanotify/fanotify09.c
> index 0eb83e2f8..e40916c08 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify09.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify09.c
> @@ -73,12 +73,14 @@ static char event_buf[EVENT_BUF_LEN];
>  static int mount_created;

>  static int fan_report_dfid_unsupported;
> +static int ignore_mark_unsupported;

>  static struct tcase {
>  	const char *tname;
>  	struct fanotify_mark_type mark;
>  	unsigned int ondir;
>  	unsigned int ignore;
> +	unsigned int ignore_flags;
>  	unsigned int report_name;
>  	const char *close_nowrite;
>  	int nevents;
> @@ -88,7 +90,7 @@ static struct tcase {
>  		"Events on non-dir child with both parent and mount marks",
>  		INIT_FANOTIFY_MARK_TYPE(MOUNT),
>  		0,
> -		0,
> +		0, 0,
>  		0,
>  		DIR_NAME,
>  		1, 0,

nit: as number of struct grow, it'd help readability to omit members with 0:
		.tname = "Events on non-dir child with both parent and mount marks",
		.mark = INIT_FANOTIFY_MARK_TYPE(MOUNT),
		.close_nowrite = DIR_NAME,
		.nevents = 1,

This is obviously non-blocker of this patch, if you agree it can be done any
time later.

Also I fixed make check warnings some time ago (i.e. checkpatch.pl), but they
got back. I might find a time to fix them (we appreciate you look after the
test, thus don't want to bother you with these tiny details).

Kind regards,
Petr


More information about the ltp mailing list