[LTP] [PATCH] pty04.c/pidfd_send_signal03.c: Drop redundant tst_reap_children()

Li Wang liwang@redhat.com
Tue Sep 13 09:33:26 CEST 2022


On Tue, Sep 13, 2022 at 2:42 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Luo,
>
> > Drop redundant calling of tst_reap_children() in cleanup() since
> > it has been called in the API (run_tests()).
>
> LGTM, I suppose that was a mistake.
>

Hmm, I slightly think that reflact a cautious thought from the author,
in case of test hit tst_brk unexpectly with invoke cleanup it can also
do reap children.

So, it's probably no harmful to keep tst_reap_children there.


-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220913/0f9d2d99/attachment.htm>


More information about the ltp mailing list