[LTP] [PATCH] pty04.c/pidfd_send_signal03.c: Drop redundant tst_reap_children()
luoxiaoyu (C)
luoxiaoyu9@huawei.com
Tue Sep 13 11:14:39 CEST 2022
Maybe I have a question to ask for.
As my understand, tst_reap_children() has been called in API even test hit tst_brk, right?
Regards,
Luo
-----origin mail-----
Re: [LTP] [PATCH] pty04.c/pidfd_send_signal03.c: Drop redundant tst_reap_children()
> On Tue, Sep 13, 2022 at 2:42 PM Petr Vorel <pvorel@suse.cz> wrote:
> > Hi Luo,
> > > Drop redundant calling of tst_reap_children() in cleanup() since
> > > it has been called in the API (run_tests()).
> > LGTM, I suppose that was a mistake.
> Hmm, I slightly think that reflact a cautious thought from the author,
> in case of test hit tst_brk unexpectly with invoke cleanup it can also
> do reap children.
> So, it's probably no harmful to keep tst_reap_children there.
Ah, thx for info. I set status rejected in patchwork.
Kind regards,
Petr
More information about the ltp
mailing list