[LTP] [PATCH v1] minmax: fix type warnings
Edward Liaw
edliaw@google.com
Tue Sep 13 22:28:39 CEST 2022
Several min/max comparisons are missing type conversions.
Signed-off-by: Edward Liaw <edliaw@google.com>
---
lib/tst_memutils.c | 2 +-
testcases/kernel/mem/mmapstress/mmapstress01.c | 2 +-
testcases/kernel/mem/mmapstress/mmapstress10.c | 2 +-
testcases/kernel/mem/tunable/overcommit_memory.c | 6 +++---
testcases/kernel/syscalls/mprotect/mprotect02.c | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/tst_memutils.c b/lib/tst_memutils.c
index 0d20bb17c..c6696437d 100644
--- a/lib/tst_memutils.c
+++ b/lib/tst_memutils.c
@@ -31,7 +31,7 @@ void tst_pollute_memory(size_t maxsize, int fillchar)
SAFE_SYSINFO(&info);
safety = MAX(4096 * SAFE_SYSCONF(_SC_PAGESIZE), 128L * 1024 * 1024);
- safety = MAX(safety, min_free);
+ safety = MAX(safety, (size_t)min_free);
safety /= info.mem_unit;
if (info.freeswap > safety)
diff --git a/testcases/kernel/mem/mmapstress/mmapstress01.c b/testcases/kernel/mem/mmapstress/mmapstress01.c
index c16b50a6d..f425c223d 100644
--- a/testcases/kernel/mem/mmapstress/mmapstress01.c
+++ b/testcases/kernel/mem/mmapstress/mmapstress01.c
@@ -310,7 +310,7 @@ int main(int argc, char *argv[])
anyfail();
}
for (bytes_left = filesize; bytes_left; bytes_left -= c) {
- write_cnt = MIN(pagesize, bytes_left);
+ write_cnt = MIN(pagesize, (int)bytes_left);
if ((c = write(fd, buf, write_cnt)) != write_cnt) {
if (c == -1) {
perror("write error");
diff --git a/testcases/kernel/mem/mmapstress/mmapstress10.c b/testcases/kernel/mem/mmapstress/mmapstress10.c
index 28b4f1e91..53f02c1f6 100644
--- a/testcases/kernel/mem/mmapstress/mmapstress10.c
+++ b/testcases/kernel/mem/mmapstress/mmapstress10.c
@@ -360,7 +360,7 @@ int main(int argc, char *argv[])
}
for (bytes_left = filesize; bytes_left; bytes_left -= c) {
- write_cnt = MIN(pagesize, bytes_left);
+ write_cnt = MIN(pagesize, (int)bytes_left);
if ((c = write(fd, (char *)buf, write_cnt)) != write_cnt) {
if (c == -1) {
perror("write error");
diff --git a/testcases/kernel/mem/tunable/overcommit_memory.c b/testcases/kernel/mem/tunable/overcommit_memory.c
index 20151ebb0..7fe8fe14c 100644
--- a/testcases/kernel/mem/tunable/overcommit_memory.c
+++ b/testcases/kernel/mem/tunable/overcommit_memory.c
@@ -248,9 +248,9 @@ static void calculate_total_batch_size(void)
SAFE_SYSINFO(&info);
/* see linux source mm/mm_init.c mm_compute_batch() (This is in pages) */
- long batch_size = MAX(ncpus * 2,
- MAX(32,
- MIN(INT32_MAX,
+ long batch_size = MAX(ncpus * 2L,
+ MAX(32L,
+ MIN((long)INT32_MAX,
(long)(info.totalram / pagesize) / ncpus / 256
)
)
diff --git a/testcases/kernel/syscalls/mprotect/mprotect02.c b/testcases/kernel/syscalls/mprotect/mprotect02.c
index de9b4ea00..da445d442 100644
--- a/testcases/kernel/syscalls/mprotect/mprotect02.c
+++ b/testcases/kernel/syscalls/mprotect/mprotect02.c
@@ -77,7 +77,7 @@ int main(int ac, char **av)
do {
- bytes_to_write = MIN(strlen(buf), num_bytes);
+ bytes_to_write = MIN((unsigned int)strlen(buf), num_bytes);
num_bytes -=
SAFE_WRITE(cleanup, 1, fd, buf, bytes_to_write);
--
2.37.2.789.g6183377224-goog
More information about the ltp
mailing list