[LTP] [PATCH 3/3] dio_sparse: Fix child exit code

Cyril Hrubis chrubis@suse.cz
Wed Sep 14 11:37:53 CEST 2022


Hi!
> dio_sparse currently ignores all child failures because children never
> exit with non-zero code. Fix child exit status.
> 
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
>  testcases/kernel/io/ltp-aiodio/common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/kernel/io/ltp-aiodio/common.h b/testcases/kernel/io/ltp-aiodio/common.h
> index 68465dc54..6265831af 100644
> --- a/testcases/kernel/io/ltp-aiodio/common.h
> +++ b/testcases/kernel/io/ltp-aiodio/common.h
> @@ -78,9 +78,9 @@ static inline void io_read(const char *filename, int filesize, volatile int *run
>  			if (r > 0) {
>  				bufoff = check_zero(buff, r);
>  				if (bufoff) {
> -					tst_res(TINFO, "non-zero read at offset %zu",
> +					tst_brk(TBROK,
> +						"non-zero read at offset %zu",
>  						offset + (bufoff - buff));

Ah, this is the fix. I would go for tst_res(TFAIL, ""); and return 1;
otherwise this looks fine applied over the previous changes.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list