[LTP] [PATCH v6 8/8] df01.sh: Convert to TST_ALL_FILESYSTEMS=1

Petr Vorel pvorel@suse.cz
Fri Sep 16 22:39:26 CEST 2022


> Hi!
> > > +TST_ALL_FILESYSTEMS=1
> > >  TST_CNT=12
> > >  TST_SETUP=setup
> > >  TST_TESTFUNC=test
> > > -TST_OPTS="f:"
> > > -TST_USAGE=usage
> > > -TST_PARSE_ARGS=parse_args
> > >  TST_NEEDS_ROOT=1
> > > -TST_MOUNT_DEVICE=1

> > Just looking at this made me realize that for C API ALL_FILESYTEMST does
> > not imply TST_MOUNT_DEVICE since these functionalities are orthogonal. I
> > think that it would be better if we had the C API and shell API as close
> > as possible, hence ALL_FILESYSTEMS should imply only NEEDS_DEVICE and
> > the MOUNT_DEVICE would stay here.
Good point, thanks! Another reason is that With ALL_FILESYSTEMS implying
TST_MOUNT_DEVICE mkfs01.sh could not use ALL_FILESYSTEMS=1.

Kind regards,
Petr

> Also with that change:

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>


More information about the ltp mailing list