[LTP] [PATCH v4 1/3] syscalls/creat09: Add umask test condition

Christian Brauner brauner@kernel.org
Wed Sep 21 17:40:25 CEST 2022


On Wed, Sep 21, 2022 at 03:55:56PM +0200, Cyril Hrubis wrote:
> Hi!
> > > Yes.  Please apply it with fix the messages. Thanks.
> > 
> > I guess you miss this patchset. so ping again.
> 
> Sorry for the delay.
> 
> I just did quick test and I got failures on XFS on kernel 5.19, wasn't
> this supposed to be fixed in 5.19?

No, this is fixed starting with v6.0-rc1 :)

> 
> ...
> creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
> creat09.c:112: TPASS: mntpoint/testdir/creat.tmp: Setgid bit not set
> creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
> creat09.c:112: TPASS: mntpoint/testdir/open.tmp: Setgid bit not set
> creat09.c:120: TINFO: File created with umask(S_IXGRP)
> creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
> creat09.c:110: TFAIL: mntpoint/testdir/creat.tmp: Setgid bit is set
> creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
> creat09.c:110: TFAIL: mntpoint/testdir/open.tmp: Setgid bit is set
> ...
> 
> $ uname -r
> 5.19.0
> 
> $ git describe 1639a49ccdce
> v5.19-rc7-3-g1639a49ccdce
> 
> 
> Is there any in-flight patch for v6.0 that fixes this for XFS?

You're looking for
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=426b4ca2d6a5ab51f6b6175d06e4f8ddea434cdf

Hope this helps!
Christian


More information about the ltp mailing list