[LTP] [PATCH 3/3 v2] tst_test.sh: Fix filesystem support detection

Petr Vorel pvorel@suse.cz
Fri Sep 23 18:36:42 CEST 2022


> Hi!
> > Fixes: 1f6bd6e66 ("tst_test.sh: Add $TST_ALL_FILESYSTEMS")

> > Reported-by: Martin Doucha <mdoucha@suse.cz>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> Looks like this is the only real fix in the series, right?

> The actual change looks good, but I do wonder what exactly has been
> broken, git grpe TST_SKIP_FILESYSTEMS does not show any real tests
> that would use that variable.

Broken were actually all shell tests which did not use TST_SKIP_FILESYSTEMS:
e.g. all tests in net_stress.ipsec_* did run whole filesystem check:

tst_supported_fs_types.c:93: TINFO: Kernel supports ext2
tst_supported_fs_types.c:55: TINFO: mkfs.ext2 does exist
tst_supported_fs_types.c:93: TINFO: Kernel supports ext3
tst_supported_fs_types.c:55: TINFO: mkfs.ext3 does exist
tst_supported_fs_types.c:93: TINFO: Kernel supports ext4
tst_supported_fs_types.c:55: TINFO: mkfs.ext4 does exist
tst_supported_fs_types.c:93: TINFO: Kernel supports xfs
tst_supported_fs_types.c:55: TINFO: mkfs.xfs does exist
tst_supported_fs_types.c:93: TINFO: Kernel supports btrfs
tst_supported_fs_types.c:55: TINFO: mkfs.btrfs does exist
tst_supported_fs_types.c:93: TINFO: Kernel supports vfat
tst_supported_fs_types.c:55: TINFO: mkfs.vfat does exist
tst_supported_fs_types.c:93: TINFO: Kernel supports exfat
tst_supported_fs_types.c:55: TINFO: mkfs.exfat does exist
tst_supported_fs_types.c:123: TINFO: FUSE does support ntfs
tst_supported_fs_types.c:55: TINFO: mkfs.ntfs does exist
tst_supported_fs_types.c:93: TINFO: Kernel supports tmpfs
tst_supported_fs_types.c:42: TINFO: mkfs is not needed for tmpfs
sctp_ipsec 1 TINFO: timeout per run is 0h 5m 0s
sctp_ipsec 1 TINFO: IPsec[ah/transport]
sctp_ipsec 1 TINFO: run server 'netstress -T sctp -S 10.0.0.1 -D ltp_ns_veth1 -R 500000 -B /tmp/LTP_sctp_ipsec.hC471AeJ9L'
...

instead checking just filesystem in TMPDIR due empty $TST_FS_TYPE (I should have
quoted it).

+ there are IMA tests had this + specific problem.

Kind regards,
Petr


More information about the ltp mailing list