[LTP] [PATCH 1/4] syscalls/mlock01: Convert into new api
Yang Xu
xuyang2018.jy@fujitsu.com
Tue Apr 4 12:36:31 CEST 2023
Also use safe macros and TST_EXP_PASS macro.
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
testcases/kernel/syscalls/mlock/mlock01.c | 159 +++++-----------------
1 file changed, 33 insertions(+), 126 deletions(-)
diff --git a/testcases/kernel/syscalls/mlock/mlock01.c b/testcases/kernel/syscalls/mlock/mlock01.c
index 2338d4d56..0b079f8be 100644
--- a/testcases/kernel/syscalls/mlock/mlock01.c
+++ b/testcases/kernel/syscalls/mlock/mlock01.c
@@ -1,145 +1,52 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
- *
- * Copyright (c) International Business Machines Corp., 2002
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
- * the GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-/*
- * NAME
- * mlock01.c
- *
- * DESCRIPTION
- * Test to see that mlock works
- *$
- * ALGORITHM
- * test 1:
- * Call mlock with various valid addresses and lengths. No
- * error should be returned
- *
- * USAGE: <for command-line>
- * -c n Run n copies concurrently
- * -e Turn on errno logging
- * -f Turn off functional testing
- * -h Show this help screen
- * -i n Execute test n times
- * -I x Execute test for x seconds
- * -p Pause for SIGUSR1 before starting
- * -P x Pause for x seconds between iterations
- * -t Turn on syscall timing
+ * Copyright (c) International Business Machines Corp., 2002
*
* HISTORY
* 06/2002 Written by Paul Larson
- *
- * RESTRICTIONS
- * None
*/
-#include <errno.h>
-#include <unistd.h>
-#include <sys/mman.h>
-#include "test.h"
-void setup();
-void setup1(int);
-void cleanup();
+/*\
+ * [Description]
+ *
+ * Test mlock with various valid addresses and lengths.
+ */
-char *TCID = "mlock01";
-int TST_TOTAL = 4;
+#include <stdlib.h>
+#include "tst_test.h"
-void *addr1;
+static void *addr;
-struct test_case_t {
- void **addr;
+static struct tcase {
+ char *msg;
int len;
- void (*setupfunc) ();
-} TC[] = {
- /* mlock should return ENOMEM when some or all of the address
- * range pointed to by addr and len are not valid mapped pages
- * in the address space of the process
- */
- {
- &addr1, 1, setup1}, {
- &addr1, 1024, setup1}, {
- &addr1, 1024 * 1024, setup1}, {
- &addr1, 1024 * 1024 * 10, setup1}
+} tcases[] = {
+ {"mlock 1 byte", 1},
+ {"mlock 1024 bytes", 1024},
+ {"mlock 1024 * 1024 bytes", 1024 * 1024},
+ {"mlock 1024 * 1024 * 10 bytes", 1024 * 1024 * 10}
};
-#if !defined(UCLINUX)
-
-int main(int ac, char **av)
-{
- int lc, i;
-
- tst_parse_opts(ac, av, NULL, NULL);
-
- setup();
-
- /*
- * FIXME (garrcoop): this should really test out whether or not the
- * process's mappable address space is indeed accessible by the
- * current user, instead of needing to be run by root all the time.
- */
- tst_require_root();
-
- for (lc = 0; TEST_LOOPING(lc); lc++) {
-
- tst_count = 0;
-
- for (i = 0; i < TST_TOTAL; i++) {
-
- if (TC[i].setupfunc != NULL)
- TC[i].setupfunc(TC[i].len);
-
- TEST(mlock(*(TC[i].addr), TC[i].len));
-
- /* I'm confused -- given the description above this
- * should fail as designed, but this application
- * */
- if (TEST_RETURN == -1)
- tst_resm(TFAIL | TTERRNO, "mlock failed");
- else
- tst_resm(TPASS, "mlock passed");
- }
- }
-
- cleanup();
-
- tst_exit();
-}
-
-#else
-
-int main(void)
+static void do_mlock(unsigned int i)
{
- tst_brkm(TCONF, NULL, "test is not available on uClinux");
-}
-
-#endif /* if !defined(UCLINUX) */
+ struct tcase *tc = &tcases[i];
-void setup(void)
-{
- TEST_PAUSE;
+ tst_res(TINFO, "%s", tc->msg);
+ addr = SAFE_MALLOC(tc->len);
+ TST_EXP_PASS(mlock(addr, tc->len), "mlock(%p, %d)", addr, tc->len);
+ free(addr);
+ addr = NULL;
}
-void setup1(int len)
+static void cleanup(void)
{
- addr1 = malloc(len);
- if (addr1 == NULL)
- tst_brkm(TFAIL, cleanup, "malloc failed");
+ if (addr)
+ free(addr);
}
-void cleanup(void)
-{
-}
+static struct tst_test test = {
+ .needs_root = 1,
+ .test = do_mlock,
+ .tcnt = ARRAY_SIZE(tcases),
+ .cleanup = cleanup,
+};
--
2.39.1
More information about the ltp
mailing list