[LTP] [PATCH 2/2] rpc/rpc-tirpc: Fix compile error on clang when using registerrpc

Yang Xu (Fujitsu) xuyang2018.jy@fujitsu.com
Wed Apr 26 03:59:40 CEST 2023


Hi Petr

> Hi Xu,
> 
>> +++ b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/rpc/rpc_regunreg_registerrpc/rpc_registerrpc.c
>> @@ -68,8 +68,8 @@ int main(int argn, char *argc[])
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
>>   	//call routine
>>   	rslt =
>> -	    registerrpc(progNum, VERSNUM, PROCNUM, simplePing, xdr_int,
>> -			xdr_int);
>> +	    registerrpc(progNum, VERSNUM, PROCNUM, simplePing,
>> +			(xdrproc_t) xdr_int, (xdrproc_t) xdr_int);
> 
> Maybe just put rslt = on the same line (to fix often broken style a bit?)
> 
> rslt = registerrpc(progNum, VERSNUM, PROCNUM, simplePing,
> 		(xdrproc_t) xdr_int, (xdrproc_t) xdr_int);

I have changed 1/2 patch commit message as you sugguested, also for this 
patch, I put them to the single line, thanks for your review, merged.

Best Regards
Yang Xu
> Kind regards,
> Petr


More information about the ltp mailing list