[LTP] [PATCH v1 1/2] fcntl{34, 36}: Only use fcntl64 with 32bit abi

[Edward Liaw]

On Thu, Apr 27, 2023 at 2:47 AM Richard Palethorpe <rpalethorpe@suse.de> wrote:
>
> Hello,
>
> Edward Liaw via ltp <ltp@lists.linux.it> writes:
>
> > Fixes: 7643115aaacb ("fcntl{34,36}: Always use 64-bit flock struct to avoid EINVAL")
> >
> > On Android arm64, tst_kernel_bits is disregarding the abi, so compiling
> > with the 32bit abi is calling the fcntl syscall instead of fcntl64.
> > The
>
> IIRC that's the idea because fcntl64 doesn't exist on a 64bit
> kernel.
>
> So if you compile the test with -m32/32bit ABI on x86_64 64bit kernel
> then you will get ENOSYS? If not then I suppose it is fine.

I did not get ENOSYS.  I checked with strace and my x86_64 bit kernel
does appear to have fcntl64 when compiled with -m32.  I'm not sure if
that's always the case, though.  I checked with the other fcntl tests
and they also appear to call fcntl64 with the 32 bit abi.