[LTP] [PATCH] fanotify23: Make evictable marks tests more reliable

[Jan Kara]

On Thu 10-08-23 17:38:15, Amir Goldstein wrote:
> On Thu, Aug 10, 2023 at 5:25 PM Jan Kara <jack@suse.cz> wrote:
> > > Meaning that the explanation is true because fanotify10 has:
> > >
> > >         /* Shrinkers on other fs do not work reliably enough to
> > > guarantee mark eviction on drop_caches */
> > >         .dev_fs_type = "ext2",
> > >
> > > Maybe that should be spelled out?
> >
> > I guess you speak about fanotify23 now but yes, this patch depends on the
> > fact that we are limited to ext2. Perhaps I can add that to the comment but
> > it already is mentioned in the test as you show above...
> 
> Yes, that is all I meant, so a reader won't see this explanation and
> try to copy the same mitigation to other tests that do not limit
> themselves to ext2, better make that fact clear in the comment.

OK, I've added a note to the comment that this is specific to the fs and
the test is limited to ext2. I'll send v2 shortly.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR