[LTP] [PATCH v1] Add more check points for Review Checklist doc
Wei Gao
wegao@suse.com
Sat Dec 30 09:26:41 CET 2023
Signed-off-by: Wei Gao <wegao@suse.com>
---
doc/Maintainer-Patch-Review-Checklist.asciidoc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/doc/Maintainer-Patch-Review-Checklist.asciidoc b/doc/Maintainer-Patch-Review-Checklist.asciidoc
index 452de0d49..8bc3468a0 100644
--- a/doc/Maintainer-Patch-Review-Checklist.asciidoc
+++ b/doc/Maintainer-Patch-Review-Checklist.asciidoc
@@ -22,6 +22,7 @@ The following are examples and may not be appropriate for all tests.
- Use sanitizers e.g. undefined behaviour, address.
- Compile on non-x86
- Compile on x86 with -m32
+ - Test patches on GitHub Actions will covers various architectures
* Use `make check`
* Run effected tests in a VM
- Use single vCPU
@@ -30,10 +31,11 @@ The following are examples and may not be appropriate for all tests.
* Run effected tests on an embedded device
* Run effected tests on non-x86 machine in general
* Run reproducers on a kernel where the bug is present
-* Run tests with "-i0"
+* Run tests with "-i0" and "-in"
* Compare usage of system calls with man page descriptions
-* Compare usage of system calls with kernel code
+* Compare usage of system calls with kernel code or commit message
* Search the LTP library for existing helper functions
+* Check doc formatting e.g. cd metadata && make && chromium ../docparse/*.html
## How to find subtle errors
--
2.35.3
More information about the ltp
mailing list