[LTP] [PATCH v1] ioctl01.c:Test also struct termios

Petr Vorel pvorel@suse.cz
Mon Feb 6 07:12:11 CET 2023


Hi Wei,

> Hi Wei,

...
> > @@ -64,7 +66,21 @@ static void verify_ioctl(unsigned int i)
> >  	if (TST_ERR != tcases[i].error) {
> >  		tst_res(TFAIL | TTERRNO,
> >  			"failed unexpectedly; expected %s",
> > -		        tst_strerrno(tcases[i].error));
> > +			tst_strerrno(tcases[i].error));
> > +		return;
> > +	}
> Could you please replace TEST(ioctl(...) with TST_EXP_FAIL(ioctl(...))?
> That would save all error handling.

> We try to use these helping macros in include/tst_test_macros.h.
> Although they would deserve some docs as macros are a bit harder to read.

I implemented this in 4c86809f77 ("ioctl01: cleanup"). Could you please rebase
your commit and use TST_EXP_FAIL() in it?

Thank you!

Kind regards,
Petr


More information about the ltp mailing list