[LTP] [PATCH 1/1] tst_pids.c: fix fork failure on small memory systems
Leo Yu-Chi Liang
ycliang@andestech.com
Tue Feb 7 13:40:08 CET 2023
Running syscalls/msgstress03 on a system with less than ~1 GB of RAM fails:
msgstress03 1 TFAIL : msgstress03.c:163: Fork failed (may be OK if under stress)
The reason is that besides /proc/sys/kernel/pid_max, /proc/sys/kernel/threads-max
is another factor determining how many processes a system could create.
Use the smaller number between pid_max and threads-max as the nprocs.
Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
lib/tst_pid.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/tst_pid.c b/lib/tst_pid.c
index 21cadef2a..3fb3f39ad 100644
--- a/lib/tst_pid.c
+++ b/lib/tst_pid.c
@@ -31,6 +31,7 @@
#include "tst_safe_macros.h"
#define PID_MAX_PATH "/proc/sys/kernel/pid_max"
+#define THREADS_MAX_PATH "/proc/sys/kernel/threads-max"
#define CGROUPS_V1_SLICE_FMT "/sys/fs/cgroup/pids/user.slice/user-%d.slice/pids.max"
#define CGROUPS_V2_SLICE_FMT "/sys/fs/cgroup/user.slice/user-%d.slice/pids.max"
/* Leave some available processes for the OS */
@@ -113,7 +114,7 @@ static int get_session_pids_limit(void (*cleanup_fn) (void))
int tst_get_free_pids_(void (*cleanup_fn) (void))
{
FILE *f;
- int rc, used_pids, max_pids, max_session_pids;
+ int rc, used_pids, max_pids, max_session_pids, max_threads;
f = popen("ps -eT | wc -l", "r");
if (!f) {
@@ -129,6 +130,8 @@ int tst_get_free_pids_(void (*cleanup_fn) (void))
}
SAFE_FILE_SCANF(cleanup_fn, PID_MAX_PATH, "%d", &max_pids);
+ SAFE_FILE_SCANF(cleanup_fn, THREADS_MAX_PATH, "%d", &max_threads);
+ max_pids = (max_pids < max_threads) ? max_pids : max_threads;
max_session_pids = get_session_pids_limit(cleanup_fn);
if ((max_session_pids > 0) && (max_session_pids < max_pids))
--
2.34.1
More information about the ltp
mailing list