[LTP] [PATCH 1/1] testscripts/network.sh: Don't load tst_net.sh

[Petr Vorel]

Hi Cyril,

> Hi!
> > Please read further info in my later reaction [1]
> > (TL;DR: not all include it, but these aren't in runtest files anyway).

> In that case:

> Acked-by: Cyril Hrubis <chrubis@suse.cz>

Merged as b45bb8924d, with updated description.

I need to spent time to resolve these old tests.
https://github.com/linux-test-project/ltp/issues/128
(updated this text below in the ticket description)

$ git grep -l LTP_RSH |grep -v -e README -e tst_net.sh -e /ns-tools/
testcases/network/stress/icmp/multi-diffip/icmp4-multi-diffip01
testcases/network/stress/icmp/multi-diffnic/icmp4-multi-diffnic01
testcases/network/stress/tcp/multi-diffip/tcp4-multi-diffip01
testcases/network/stress/tcp/multi-diffnic/tcp4-multi-diffnic01
testcases/network/stress/tcp/multi-diffport/tcp4-multi-diffport01
testcases/network/stress/tcp/multi-sameport/tcp4-multi-sameport01
testcases/network/stress/tcp/uni-basic/tcp4-uni-basic01
testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01
testcases/network/stress/udp/multi-diffnic/udp4-multi-diffnic01
testcases/network/stress/udp/multi-diffport/udp4-multi-diffport01
testcases/network/stress/udp/uni-basic/udp4-uni-basic01

These tests using similar IPsec proto/mode params, which are in
runtest/net_stress.ipsec_{dccp,icmp,sctp,tcp,udp}. These new and well working
tests are using ipsec_lib.sh and are testing either with ping via tst_ping()
(ICMP tests) or with netstress.c via tst_netload() (the rest of the tests).

The old legacy tests are using various TCP/UDP client-server and ICMP sender
tools from testcases/network/stress/ns-tools/. To decide whether they can be
safely deleted or should be kept (and cleanup and possibly migrated to
ipsec_lib.sh) is whether their C tools they use test other kernel functionality
than netstress.c and ping.

There is also ns-igmp_querier.c, which is used in mcast-lib.sh, which should be
cleaned (probably not a candidate to put the code into netstress.c), but that's
another case.

Once this all is solved, several shell scripts in
testcases/network/stress/ns-tools/ can be deleted.

Kind regards,
Petr