[LTP] [PATCH v4] Refactor pidns30 test using new LTP API

Andrea Cervesato andrea.cervesato@suse.com
Tue Feb 14 13:17:06 CET 2023


Hi,

beware that now gcc raises a warning:

    pidns31.c: In function ‘run’:
    pidns31.c:72:6: warning: unused variable ‘status’ [-Wunused-variable]
       int status;
           ^~~~~~

Andrea

On 2/14/23 10:47, Richard Palethorpe wrote:
> Hello,
>
> Merged, thanks!
>
> Andrea Cervesato via ltp<ltp@lists.linux.it>  writes:
>
>> Hi,
>>
>> On 2/10/23 14:16, Cyril Hrubis wrote:
>>> Hi!
>>>> +static void run(void)
>>>>    {
>>>> -	int status;
>>>> -	char buf[5];
>>>> -	pid_t cpid;
>>>> +	const struct tst_clone_args args = { CLONE_NEWPID, SIGCHLD };
>>>>    -	setup();
>>>> +	remove_mqueue(mqd);
>>>> +	received = 0;
>>> I wonder if we really need to clear the flag here, as far as I can see
>>> we only modify that variable in the child process and that shouldn't
>>> propagate to parent, unless we pass CLONE_VM of course.
>> Flag reset has been added to be 100% sure we are receiving the signal
>> on -i > 1.
>>> Other than this it looks really good:
>>>
>>> Reviewed-by: Cyril Hrubis<chrubis@suse.cz>
>>>
>> Andrea
>


More information about the ltp mailing list