[LTP] [PATCH v2] rseq01: basic test rseq
Cyril Hrubis
chrubis@suse.cz
Thu Feb 16 11:58:22 CET 2023
Hi!
> Add basic check for the newly added glibc API in LTP.
> This test references the glibc test case tst-rseq.c.
>
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
> configure.ac | 1 +
> include/lapi/rseq.h | 57 +++++++++++++++++++++++
> runtest/syscalls | 2 +
> testcases/kernel/syscalls/rseq/.gitignore | 1 +
> testcases/kernel/syscalls/rseq/Makefile | 7 +++
> testcases/kernel/syscalls/rseq/rseq01.c | 28 +++++++++++
> 6 files changed, 96 insertions(+)
> create mode 100644 include/lapi/rseq.h
> create mode 100644 testcases/kernel/syscalls/rseq/.gitignore
> create mode 100644 testcases/kernel/syscalls/rseq/Makefile
> create mode 100644 testcases/kernel/syscalls/rseq/rseq01.c
>
> diff --git a/configure.ac b/configure.ac
> index c2b0f48e7..43b9ca3ce 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -80,6 +80,7 @@ AC_CHECK_HEADERS_ONCE([ \
> sys/utsname.h \
> sys/xattr.h \
> xfs/xqm.h \
> + sys/rseq.h \
> ])
> AC_CHECK_HEADERS(fts.h, [have_fts=1])
> AC_SUBST(HAVE_FTS_H, $have_fts)
> diff --git a/include/lapi/rseq.h b/include/lapi/rseq.h
> new file mode 100644
> index 000000000..7f4834f2c
> --- /dev/null
> +++ b/include/lapi/rseq.h
> @@ -0,0 +1,57 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2021-2023 Free Software Foundation, Inc.
> + * Copyright (c) 2023 Wei Gao <wegao@suse.com>
> + */
> +
> +#ifndef LAPI_RSEQ_H__
> +#define LAPI_RSEQ_H__
> +
> +#include <errno.h>
> +#include <unistd.h>
> +#include <stdbool.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <syscall.h>
> +#include "config.h"
> +#include "tst_test.h"
> +
> +
> +#if defined(HAVE_SYS_RSEQ_H)
> +# include <sys/rseq.h>
> +#endif
> +
> +
> +#if defined(HAVE_SYS_RSEQ_H) && defined(RSEQ_SIG)
^
Where is this macro
defined?
> +static int sys_rseq(struct rseq *rseq_abi, uint32_t rseq_len, int flags, uint32_t sig)
> +{
> + return syscall(__NR_rseq, rseq_abi, rseq_len, flags, sig);
^
tst_syscall
> +}
> +
> +static void check_rseq_available(void)
> +{
> + int rc;
> +
> + rc = sys_rseq(NULL, 0, 0, 0);
> + if (rc != -1)
> + tst_brk(TFAIL | TTERRNO, "Unexpected rseq return value %d ", rc);
> + switch (errno) {
> + case ENOSYS:
> + tst_brk(TCONF,
> + "kernel does not support rseq, skipping test");
> + case EINVAL:
> + /* rseq is implemented, but detected an invalid rseq_len parameter. */
> + break;
> + default:
> + tst_brk(TFAIL | TTERRNO, "Unexpected rseq error ");
> + }
> +}
These two functions should be defined regardless of the presense of the
sys/rqseq.h header.
The configure checks for the header are there to ensure there are no
collisions between the function/macro definitions we carry in LTP and
the ones in the libc library.
More generally there is no correlation between kernel version and libc
version installed on the system. We deal with that in LTP by adding:
- configure check for particular functionality
- fallback definitions in lapi/ headers in case that system headers
does not include the definitions we need
- syscall availability check in the test setup()
With that we can run the test if the syscall() is supported by kernel
and exit greacefuly otherwhise.
> +#else /* HAVE_SYS_RSEQ_H && RSEQ_SIG */
> +static void check_rseq_available(void)
> +{
> + tst_brk(TCONF,
> + "glibc does not support rseq, skipping test");
> +}
> +#endif /* HAVE_SYS_RSEQ_H && RSEQ_SIG */
> +
> +#endif /* LAPI_RSEQ_H__ */
> diff --git a/runtest/syscalls b/runtest/syscalls
> index ae37a1192..f46950b27 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -1752,6 +1752,8 @@ copy_file_range01 copy_file_range01
> copy_file_range02 copy_file_range02
> copy_file_range03 copy_file_range03
>
> +rseq01 rseq01
> +
> statx01 statx01
> statx02 statx02
> statx03 statx03
> diff --git a/testcases/kernel/syscalls/rseq/.gitignore b/testcases/kernel/syscalls/rseq/.gitignore
> new file mode 100644
> index 000000000..8a6c7ee36
> --- /dev/null
> +++ b/testcases/kernel/syscalls/rseq/.gitignore
> @@ -0,0 +1 @@
> +/rseq01
> diff --git a/testcases/kernel/syscalls/rseq/Makefile b/testcases/kernel/syscalls/rseq/Makefile
> new file mode 100644
> index 000000000..159d5651c
> --- /dev/null
> +++ b/testcases/kernel/syscalls/rseq/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (C) 2012 Linux Test Project, Inc.
> +
> +top_srcdir ?= ../../../..
> +
> +include $(top_srcdir)/include/mk/testcases.mk
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> diff --git a/testcases/kernel/syscalls/rseq/rseq01.c b/testcases/kernel/syscalls/rseq/rseq01.c
> new file mode 100644
> index 000000000..6f3e7ff97
> --- /dev/null
> +++ b/testcases/kernel/syscalls/rseq/rseq01.c
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2021-2023 Free Software Foundation, Inc.
> + * Copyright (c) 2023 Wei Gao <wegao@suse.com>
> + */
> +
> +/*\
> + * [Description]
> + *
> + * Restartable Sequences basic tests.
> + */
> +
> +#define _GNU_SOURCE
> +#include <stdio.h>
> +#include <sched.h>
> +#include "lapi/rseq.h"
> +
> +static void run(void)
> +{
> + check_rseq_available();
> +
> + TST_EXP_PASS(!(sched_getcpu() >= 0));
This does not actually check anything useful.
Very basic test would register rqseq, then loop over available CPUs, pin
a process to the CPU and check that rqsed did register the buffers. The
very basic test would look like:
https://github.com/torvalds/linux/blob/master/tools/testing/selftests/rseq/basic_test.c
> +}
> +
> +static struct tst_test test = {
> + .test_all = run,
> + .needs_root = 1,
> +};
> --
> 2.35.3
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list