[LTP] [PATCH 1/3] shell: Remove old kernel version check below 3.10

Petr Vorel pvorel@suse.cz
Tue Jan 3 19:13:06 CET 2023


Hi Xu,

...
> This evaluates to FLAG_PREFIX=
> => please remove the variable as it's always empty

> >  		/bin/echo "$FLAGS_SET" | while read -r FLAG_LINE ; do
> >  			/bin/echo -n "$FLAG_LINE" \
> >  				| awk -v prf="$FLAG_PREFIX" -F " |:" \
> change to:
>   				| awk -v prf= -F " |:" \

FYI I suggested:
 
>   				| awk -v prf= -F " |:" \

But you added: prf=-F (no space between =), which broke cleanup.

Fixed in af98698067.

And yes, prf variable is not needed at all, I'll try to find time to cleanup
dynamic_debug01.sh.

Kind regards,
Petr

> NOTE: I'm going to cleanup the test after you merge (/bin/echo + variables).

> With these changes:
> Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Kind regards,
> Petr


More information about the ltp mailing list