[LTP] [PATCH 1/1] github: Improve pull request template

Avinesh Kumar akumar@suse.de
Tue Jan 10 11:38:30 CET 2023


On Tuesday, January 10, 2023 3:56:35 PM IST Petr Vorel wrote:
> Hi Richie, Avinesh,
> 
> thanks for your review.
> > Hello,
> 
> > Please merge.
> Before merge, are you ok with one more change?
> 
> Kind regards,
> Petr
> 
> +++ .github/pull_request_template.md
> @@ -9,6 +9,11 @@ We also have a patchwork instance: https://patchwork.ozlabs.org/project/ltp/list
>  * Commits should be signed: Signed-off-by: Your Name <me@example.org>, see
>  https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>  
> +* Commit message should be meaningful, following common style
> +https://www.kernel.org/doc/html/latest/process/submitting-patches.html#split-changes
> +https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> +https://chris.beams.io/posts/git-commit/
+1 for the change, as long as the last url can be considered reliable. It already redirects to another website for me.

> +
>  * New code should follow Linux kernel coding style, see
>  https://www.kernel.org/doc/html/latest/process/coding-style.html.
>  You can run 'make check' or 'make check-foo' in the folder with modified code to check style and common errors.
> 


Regards,
Avinesh





More information about the ltp mailing list