[LTP] [PATCH v4] Add PATH to tst_rhost_run.sh

Petr Vorel pvorel@suse.cz
Tue Jan 17 09:26:13 CET 2023


Hi Wei, all,

I at least once reproduced the problem:
# ./tst_rhost_run.sh
RTNETLINK answers: File exists
tst_rhost_run 1 TBROK: ip li add name ltp_ns_veth1 type veth peer name ltp_ns_veth2 failed

I can't reproduce it now, let's skip it.

Unfortunately there is another problem, which can't be solved with adjusting
PATH for the test, because also remote end would need to have PATH adjusted
With this patch and with your another patch [1]:

# ./tst_rhost_run.sh
...
tst_rhost_run 1 TINFO: tst_rhost_run: cmd: tst_net_iface_prefix -r 10.0.0.1
tst_rhost_run 1 TINFO: NETNS: ns_exec 17258 net,mnt sh -c " tst_net_iface_prefix -r 10.0.0.1 || echo RTERR" 2>&1
./../../../..//testcases/lib/tst_net.sh: line 1027: sh:: command not found
tst_rhost_run 1 TINFO: tst_rhost_run: cmd: tst_net_iface_prefix -r fd00:1:1:1::1
tst_rhost_run 1 TINFO: NETNS: ns_exec 17258 net,mnt sh -c " tst_net_iface_prefix -r fd00:1:1:1::1 || echo RTERR" 2>&1
./../../../..//testcases/lib/tst_net.sh: line 1032: sh:: command not found
...
tst_rhost_run 1 TPASS: tst_rhost_run is working

=> test claims TPASS, but it actually does not work properly (false negative).

Therefore instead of adjusting PATH I want to fix it properly, i.e. moving
to testcases/kernel/containers/share/ (described previously).

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/project/ltp/patch/20230117040132.5245-1-wegao@suse.com/


More information about the ltp mailing list