[LTP] [PATCH 2/2] hugemmap15.c: Use TST_TEST_TCONF() for unsupported archs

Petr Vorel pvorel@suse.cz
Thu Jan 26 11:36:40 CET 2023


Hi Cyril,

...
> > +#else
> > +	TST_TEST_TCONF("Architecture not supported");
>                           ^
> 			  Maybe I would change this to be closer to the
> 			  original, so that it's clear that a piece of
> 			  code needs to be written for the test to be
> 			  enabled and that this is not inherently not
> 			  supported

> Something as:

> 	TST_TEST_TCONF("Signal handler for this architecture hasn't been written");

Very good idea, thanks!
I wait little longer for more input and merge later today.

Kind regards,
Petr

> Other than this it looks fine, with a better message:

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>


More information about the ltp mailing list