[LTP] [PATCH 1/2] syscalls/geteuid01: Convert into new api
Petr Vorel
pvorel@suse.cz
Mon Jul 3 06:31:14 CEST 2023
Hi Xu,
make check-geteuid01 reports a lot of errors.
Some of them are to compat_tst_16.h (missing static would be easy to add),
others are related to this file.
> testcases/kernel/syscalls/geteuid/geteuid01.c | 88 ++++-----------------------
> +//SPDX-License-Identifier: GPL-2.0-only
geteuid01.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
// SPDX-License-Identifier: GPL-2.0-only
> /*
> * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved.
Maybe adding your or LTP license?
...
> + * AUTHOR : William Roske
> + * CO-PILOT : Dave Fenner
Maybe just:
* Author: William Roske, Dave Fenner
> */
> /*
This must be /*\, otherwise it will to be taken by our parser.
> + * [Description]
> + *
> + * Check the basic functionality of the geteuid() system call.
> */
...
> + TST_EXP_POSITIVE(GETEUID(),"geteuid");
geteuid01.c:20: ERROR: space required after that ',' (ctx:VxV)
TST_EXP_POSITIVE(GETEUID(), "geteuid");
Kind regards,
Petr
More information about the ltp
mailing list