[LTP] [PATCH] hugeshmctl02: Skipped EFAULT tests for libc variant

Thu Jul 6 05:13:15 CEST 2023

Hi All,

Thanks for reviewing this patch.

> Hi All,

> Reviewed-by: Petr Vorel <pvorel@suse.cz> LGTM.

> > Hi!
> > > > Okay, sounds reasonable. I agree with this.

> > > BTW I also get ENOMEM on my laptop (currently 1G free space):
> > > hugeshmctl02.c:119: TBROK: shmget #1: ENOMEM (12)

> > > Should we handle it somehow?

> > The line 119 looks suspicions, in latest git the hugeshmctl02.c does
> > not even have 119 lines.
> Well, it occurred with this patch (file has with it 147 lines). Previously the version from master worked, but now it also reports ENOMEM even on master:
> hugeshmctl02.c:87: TBROK: shmget #1: ENOMEM (12) (therefore not this patch specific). Should we use .min_mem_avail? (not sure which value).

This patch only adds a set of test variants, and does not modify the content of the test items. I think this error should have nothing to do with this patch, maybe another patch can be sent to solve the "ENOMEM" problem.

> nit: The patch subject is "hugeshmctl02: Skipped EFAULT tests for libc variant".
> "Skipped" => "Skip" (we use imperative mood).
> IMHO more important is the fact, that test variant was added, that's what I'd mention in the subject. Of course, I'd keep in the commit message body that libc variant was skipped.

Thanks for the correction. Do I have to submit a V2 patch to fix the title?

> Kind regards,
> Petr

CONFIDENTIALITY NOTICE:

This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.