[LTP] [PATCH] hugeshmctl02: Skipped EFAULT tests for libc variant

[Petr Vorel]

Hi All,

Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM.

> Hi!
> > > Okay, sounds reasonable. I agree with this.

> > BTW I also get ENOMEM on my laptop (currently 1G free space):
> > hugeshmctl02.c:119: TBROK: shmget #1: ENOMEM (12)

> > Should we handle it somehow?

> The line 119 looks suspicions, in latest git the hugeshmctl02.c does not
> even have 119 lines.
Well, it occurred with this patch (file has with it 147 lines). Previously the
version from master worked, but now it also reports ENOMEM even on master:
hugeshmctl02.c:87: TBROK: shmget #1: ENOMEM (12)
(therefore not this patch specific). Should we use .min_mem_avail? (not sure
which value).

nit: The patch subject is "hugeshmctl02: Skipped EFAULT tests for libc variant".
"Skipped" => "Skip" (we use imperative mood).
IMHO more important is the fact, that test variant was added, that's what I'd
mention in the subject. Of course, I'd keep in the commit message body that
libc variant was skipped.

Kind regards,
Petr