[LTP] [PATCH 0/3] Fix O_DIRECT definition for various archs

Petr Vorel pvorel@suse.cz
Wed Jun 28 10:18:28 CEST 2023


Hi,

this work is based on Neil's report.

I'm not sure if better would be  if the fallback O_DIRECT definition
would be removed everywhere and tests just define _GNU_SOURCE (no
library code is using O_DIRECT atm).

But the problem was found when we during some debugging use lapi/fcntl.h
inside of the library (where we don't want to set _GNU_SOURCE, otherwise
all C based LTP tests would be _GNU_SOURCE).

Kind regards,
Petr

Petr Vorel (3):
  lapi/fcntl.h: Fix O_DIRECT definition for various archs
  fsstress/global.h: Include lapi/fcntl.h
  ltpscsi/scsimain.c: Remove O_DIRECT fallback definition

 include/lapi/fcntl.h                        | 11 ++++++++++-
 testcases/kernel/fs/fsstress/global.h       |  2 +-
 testcases/kernel/fs/scsi/ltpscsi/scsimain.c |  5 +----
 3 files changed, 12 insertions(+), 6 deletions(-)

-- 
2.40.1



More information about the ltp mailing list