[LTP] [PATCH v2] mprotect: Add mprotect05 testcase

Cyril Hrubis chrubis@suse.cz
Thu Mar 2 21:09:10 CET 2023


Hi!
> > Add a test that uses mprotect to split and combine VMAs.  Created to
> > ensure the correctness of the VMA iterator after a bug report.
> 
> LGTM, thank you.
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> ...
> > +/*\
> > + * [Description]
> > + *
> > + *	Testcase to check the mprotect(2) system call split and merge
> > + *
> > + * Reference links:
> > + *  - https://bugzilla.kernel.org/show_bug.cgi?id=217061
> This would be formatted as inline in our docs.
> > + *
> > + */
> > +
> > +#include <errno.h>
> > +#include <stdio.h>
> These aren't needed.
> 
> Waiting little longer for any feedback before merging with the diff below.

Can we also add a git tag to the test? It looks like fix is in mainline
in:

commit 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
Author: Liam R. Howlett <Liam.Howlett@oracle.com>
Date:   Fri Feb 24 16:20:55 2023 -0500

    mm/mprotect: Fix successful vma_merge() of next in do_mprotect_pkey()


-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list