[LTP] [PATCh v2] madvise06: stop throwing failure when MADV_WILLNEED is ignored

Li Wang liwang@redhat.com
Mon Mar 13 11:59:29 CET 2023


On Mon, Mar 13, 2023 at 6:20 PM Richard Palethorpe <rpalethorpe@suse.de>
wrote:

> Hello,
>
> Li Wang <liwang@redhat.com> writes:
>
> > Hi,
> >
> > On Fri, Mar 3, 2023 at 3:44 PM Petr Vorel <pvorel@suse.cz> wrote:
> >
> >> Hi Li,
> >>
> >> LGTM.
> >> Acked-by: Petr Vorel <pvorel@suse.cz>
> >>
> >
> > Thank you for your ack, Petr.
> >
> > I still want Richard gives me a final check.
> >
> > @Richard, do you agree with pushing it, or other thoughts?
>
> I think it needs at least one unconditional tst_res(TPASS, ...)
> otherwise the library will report TBROK if there is no pass or fail
> result.
>
> Possibly just tst_res(TPASS, "Nothing bad happend probably") at the end
> or check for kernel taints.
>

Good point!!!

I added the kernel taint check and pushed. Thanks~



>
> With that:
> Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
>
> Sorry for slow response.
>
> --
> Thank you,
> Richard.
>
>

-- 
Regards,
Li Wang


More information about the ltp mailing list