[LTP] [PATCH v3] madvise11.c:Check loadable module before rmmod

[Richard Palethorpe]

Hello,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> > Sounds like a bug that shoudl be fixed, we probably need to create two
>> > search strings, one with dashes and one with underscores and try to
>> > strstr() both.
>> 
>> Could we not check kconfig for builtin modules?
>
> Are we 100% sure that the module-name always translates to
> CONFIG_MODULE_NAME?

I'm fairly sure this is not the case because I have spent quite some
time trying to match modules with their configuration parameters.

I had not considered trying that, but specifying the module names and
config parameters separately.

>
> I would say that we are a bit safer if we use the same files the rest of
> the tooling uses e.g. depmod, dracut etc.

I suppose that copying the logic from depmod would be safest.

-- 
Thank you,
Richard.