[LTP] [PATCH v3 1/2] Move semaphore/ tests to semop/

[Li Wang]

Petr Vorel <pvorel@suse.cz> wrote:

Hi Wei,
>
> > There is no point in having two different directories with semop()
> > testcaes so it would make sense to move these two tests into the
> > syscalls/ipc/semop/ directory as semop04 and semop05.
> > So we move ipc/semaphore/ tests to syscalls/ipc/semop/.
> > Also update runtest files accordingly.
>


> As I already stated, I'm not really sure this is good to do, but maybe I'm
> missing something.  I wonder what others think about it.
>

This patch makes sense. Petr, I know what you're concerned about,
but it is correct to move them into syscalls/ipc/semop/.

They essentially all belong to System V IPC way to use
semaphore which includes <sys/sem.h>:
  semid_ds
  semget()
  semctl()
  semop()

To distinguish from another POSIX IPC way which
include <semaphore.h>:
  sem_open()
  sem_close()
  sem_unlink()
  sem_post(), sem_wait()
  sem_getvalue()
  sem_init()
  sem_destrory()

The sem02.c needs '-lpthread' only because it invoked pthread_attr_init/exit
functions in the test, but not any POSIX IPC functions.

So you have my reviewed-by in patch v4:
Reviewed-by: Li Wang <liwang@redhat.com>


-- 
Regards,
Li Wang