[LTP] [PATCH] Add goals of patch review and tips

Petr Vorel pvorel@suse.cz
Mon Mar 20 09:04:15 CET 2023


Hi all,

...
> > +## Maintainers Checklist

> >  Patchset should be tested locally and ideally also in maintainer's fork in
> >  GitHub Actions on GitHub.
> I'd encourage people to enable GitHub Actions in their forks (I'm not sure how

> many maintainers do this; best would be automation [1] [2], but nobody bothers
> about CI and I'm sort of burn out driving it myself).

+ also add Tested: link-to-github-actions-run below --- in patch would help
(it's than obvious that maintainer does not have to bother with doing it or
not hope that it fails on CentOS 7 old compiler or very new Fedora compiler).

Maybe also encourage people to create account in the patchwork and maintain
status their patches would help (set "Superseded" if they sent new patch version,
other statuses like "Accepted" or "Changes requested" are also sometimes
forgotten by the maintainer who post comments or merge the patch).

Both of these are small helps, but they still help LTP maintainers to have more
time for the review or for writing own patches.

But I can post a follow-up patch with these after your patch is merged if you
don't want to formulate them.

Kind regards,
Petr

> Kind regards,
> Petr

> [1] https://github.com/linux-test-project/ltp/issues/599
> [2] https://github.com/linux-test-project/ltp/issues/600


More information about the ltp mailing list