[LTP] [PATCH v6 2/6] lapi/stat.h: Add STATX_DIOALIGN related definition

[Yang Xu (Fujitsu)]

on 2023/05/19 14:26, Yang, Xiao/杨 晓 wrote:
> On 2023/5/18 14:10, Xiao Yang (Fujitsu) wrote:
>> Hi Xu
>>
>> LGTM.
>> Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>
>>
>> Best Regards,
>> Xiao Yang
>>
>> On 2023/5/15 15:11, Yang Xu wrote:
>>> Also add missing stx_mnt_id.
>>>
>>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>>> ---
>>>     include/lapi/stat.h | 10 +++++++++-
>>>     1 file changed, 9 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/lapi/stat.h b/include/lapi/stat.h
>>> index 590ccd111..6ed4b6637 100644
>>> --- a/include/lapi/stat.h
>>> +++ b/include/lapi/stat.h
>>> @@ -97,7 +97,11 @@ struct statx {
>>>     	uint32_t	stx_dev_major;
>>>     	uint32_t	stx_dev_minor;
>>>     	/* 0x90 */
>>> -	uint64_t	__spare2[14];
>>> +	uint64_t	stx_mnt_id;
>>> +	uint32_t	stx_dio_mem_align;
>>> +	uint32_t	stx_dio_offset_align;
>>> +	/* 0xa0 */
>>> +	uint64_t	__spare3[12];
> Hi Xu,
> 
> After looking into the logic of statx10 and statx11, I think it's
> unnecessary to add these new members into struct statx.

Agree. Let glibc decide whether to run these cases sounds more meaingful 
and clean, will remove it.

Best Regards
Yang Xu
> 
> Best Regards,
> Xiao Yang
> 
>>>     	/* 0x100 */
>>>     };
>>>     #endif
>>> @@ -180,6 +184,10 @@ static inline int statx(int dirfd, const char *pathname, unsigned int flags,
>>>     # define STATX_MNT_ID		0x00001000U
>>>     #endif
>>>     
>>> +#ifndef STATX_DIOALIGN
>>> +# define STATX_DIOALIGN		0x00002000U
>>> +#endif
>>> +
>>>     #ifndef STATX_ALL
>>>     # define STATX_ALL		0x00000fffU
>>>     #endif