[LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails

Martin Doucha mdoucha@suse.cz
Mon Nov 13 16:46:06 CET 2023


On 25. 09. 23 19:40, Petr Vorel wrote:
> Hi,
> 
> ...
>>>>> -			umount $local_dir
>>>>> +			umount $local_dir || tst_res TFAIL "Unmount failed"
> 
>>>> I suppose that this should be TBROK instead. And that this, apart from
> 
>>> Right, TBROK looks to be the best.
>>> Martin, if you're ok with the change, I'll update it before merge (after the
>>> release).
>> I don't see the point. This is a cleanup function. The TBROK will be changed
>> to TWARN and the test will continue anyway.
> 
> But TFAIL in cleanup function looks to me strange as well. Should we endup with
> TWARN then?

TWARN makes sense. Feel free to change it during merge.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic



More information about the ltp mailing list