[LTP] [PATCH 3/6] fanotify: Switch event and mark tests to *_on_fs() variant

Jan Kara jack@suse.cz
Thu Nov 30 10:29:06 CET 2023


On Wed 29-11-23 14:46:39, Petr Vorel wrote:
> Hi Jan, Amir,
> 
> > Switch event availability and mark type availability tests to be
> > performed on the filesystem actually used for testing instead of on the
> > current directory. This is more reliable as not all filesystems support
> > the same set of features.
> 
> Jan, unfortunately this commit breaks fanotify09 and fanotify10 on SLES15 based kernels:
> 
> # ./fanotify09
> tst_device.c:97: TINFO: Found free device 0 '/dev/loop0'
> tst_test.c:1106: TINFO: Formatting /dev/loop0 with ext2 opts='' extra opts=''
> mke2fs 1.46.4 (18-Aug-2021)
> tst_test.c:1120: TINFO: Mounting /dev/loop0 to /tmp/LTP_fanRt2Q1k/fs_mnt fstyp=ext2 flags=0
> tst_test.c:1690: TINFO: LTP version: 20230929-156-gf7f69b7ef
> tst_test.c:1576: TINFO: Timeout per run is 0h 00m 30s
> fanotify.h:210: TBROK: fanotify_mark (3, FAN_MARK_ADD, ..., AT_FDCWD, fs_mnt) failed: EINVAL (22)
> ...

Thanks for testing! Indeed this was a bug in Amir's original test function
which I didn't notice. I've fixed it up.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR


More information about the ltp mailing list