[LTP] [PATCH 3/3] link08: Convert docs to docparse
Petr Vorel
pvorel@suse.cz
Thu Oct 12 11:58:23 CEST 2023
Hi Xu,
...
> +++ b/testcases/kernel/syscalls/link/link08.c
> @@ -3,21 +3,23 @@
> * Copyright (c) 2014 Fujitsu Ltd.
While you're in it, maybe update the copyright?
* Copyright (c) Linux Test Project, 2014-2022
> * Author: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
> */
> -/*
> - * Test Description:
> - * Verify that,
> - * 1. link() fails with -1 return value and sets errno to EPERM
> - * if oldpath is a directory.
> - * 2. link() fails with -1 return value and sets errno to EXDEV
> - * if oldpath and newpath are not on the same mounted file system( Linux
> - * permits a file system to be mounted at multiple points, but link()
> - * does not work across different mount points, even if the same
> - * file system is mounted on both. ).
> - * 3. link() fails with -1 return value and sets errno to EROFS
> - * if the file is on a read-only file system.
> - * 4. link() fails with -1 return value and sets errno to ELOOP
> - * if too many symbolic links were encountered in resolving path.
> +
> +/*\
> + * [Description]
I would keep the sentence:
"Verify that"" or "Test that:"
Beware, there must be a blank line before the list, otherwise list will not be
formatted as list, but inline.
With this change:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> + *
> + * - link() fails with -1 return value and sets errno to EPERM
> + * if oldpath is a directory.
> + * - link() fails with -1 return value and sets errno to EXDEV
> + * if oldpath and newpath are not on the same mounted file system( Linux
> + * permits a file system to be mounted at multiple points, but link()
> + * does not work across different mount points, even if the same
> + * file system is mounted on both. ).
> + * - link() fails with -1 return value and sets errno to EROFS
> + * if the file is on a read-only file system.
> + * - link() fails with -1 return value and sets errno to ELOOP
> + * if too many symbolic links were encountered in resolving path.
> */
> +
More information about the ltp
mailing list