[LTP] [PATCH 2/3] link05: Convert docs to docparse
Petr Vorel
pvorel@suse.cz
Thu Oct 12 12:08:12 CEST 2023
Hi Xu,
> +++ b/testcases/kernel/syscalls/link/link05.c
> @@ -1,12 +1,14 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved.
> - * AUTHOR : Richard Logan
> - * CO-PILOT : William Roske
> + * AUTHOR : Richard Logan
> + * CO-PILOT : William Roske
* Authors: Richard Logan, William Roske
> * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>
* Copyright (c) Linux Test Project, 2001-2023
> */
With this fixed:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> -/*
> +/*\
> + * [Description]
> + *
> * Test if link(2) fails with EMLINK.
> */
I was thinking how to cleanup test a bit. I don't like the loop
(SAFE_STAT(fname, &fbuf)). It could be simplified with putting
the loop into .tcnt = 1000, if (1000) (and put 1000 to #define).
Also it mixes tabs and spaces (visible in make check-link05,
spaces should be converted to tabs).
Kind regards,
Petr
More information about the ltp
mailing list