[LTP] [PATCH 1/4] readlinkat: Remove readlinkat fallback definition

Yang Xu (Fujitsu) xuyang2018.jy@fujitsu.com
Tue Oct 17 08:21:32 CEST 2023

Hi Petr,
> Hi Yang,
>> Looking at man readlinkat, it was added into kernel 2.6.16 and since the
>> oldest kernel we support is 3.10 (see doc/supported-kernel-libc-versions
>> .txt) we can as well completely drop this fallback definition.
> Again, as I mentioned in v2 renameat() patch [1], the real reason for this lapi
> function was IMHO missing glibc wrapper.  The correct git commit message should
> have been glibc wrapper was added in ...
> Also, without kernel support the function would not work at all, therefore it is
> irrelevant when readlinkat was added into kernel. That applies to all git commit
> messages. Due me merged v2 renameat() first, this is not applicable (patch must
> be modified, I'm sorry).
> This particular patch would deserve to note that since these 2 commits the lapi
> is not even used (both released in 20230929 - a proof it can be really deleted):
> 0959b893a ("syscalls/readlinkat01: Convert to new API")
> bcafe2971 ("syscalls/readlinkat02: Convert to new API")
> Kind regards,
> Petr
> [1] https://lore.kernel.org/ltp/20231016080349.GA844528@pevik/

OK.Thanks for the patient review.I'll modify it.

Best Regard,

Yang Xu

More information about the ltp mailing list