[LTP] [CI FAILURE] Re: [PATCH v4] Add test for UI_GET_NAME ioctl

Petr Vorel pvorel@suse.cz
Tue Oct 24 11:10:52 CEST 2023

Hi all,

> Hi!
> I've adjusted the FAIL/PASS messages and pushed, thanks.

UI_GET_NAME() from include/uapi/linux/uinput.h is not on the old CentOS 7 we
still support:

/__w/ltp/ltp/testcases/kernel/input/input_helper.c:194:2: error: implicit declaration of function 'UI_GET_SYSNAME' [-Werror=implicit-function-declaration]
  SAFE_IOCTL(NULL, fd, UI_GET_SYSNAME(sizeof(sys_name)), sys_name, NULL);

I'll have look later today for the fix. I suppose we need lapi/uinput.h with
adds a fallback definition. It was added in kernel v3.15 in
e3480a61fca7 ("Input: uinput - add UI_GET_SYSNAME ioctl to retrieve the sysfs path")

Also, there is also an API version change, we could use this if simple ifndef
UI_GET_SYSNAME + fallback will not be enough (e.g. test fails because it
requires newer kernel API).

-#define UINPUT_VERSION         3
+#define UINPUT_VERSION         4

Kind regards,

More information about the ltp mailing list