[LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax
Petr Vorel
pvorel@suse.cz
Mon Oct 30 08:28:19 CET 2023
Hi Li,
> Hi Petr,
> Petr Vorel <pvorel@suse.cz> wrote:
> > DEF_16 := TST_USE_COMPAT16_SYSCALL
> > ...
> > -%_16: CPPFLAGS += -D$(DEF_16)=1
Not related to this effort: shouldn't we convert all CPPFLAGS to CFLAGS? Or the
LTP build system it just prepared to the crazy ideas about using C++? :)
> Seems we need to keep this one line, otherwise it can't transfer the
> 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.
Ah, thanks!
> The rest looks good to me.
> Reviewed-by: Li Wang <liwang@redhat.com>
BTW I'm going to push it with you as an author + with your Signed-off-by: tag
(you're effectively the autor of the code) and with my RBT.
Kind regards,
Petr
More information about the ltp
mailing list