[LTP] [PATCH] Use correct ioctl request for termios

Marius Kittler mkittler@suse.de
Mon Sep 4 17:18:00 CEST 2023


Am Montag, 4. September 2023, 17:04:51 CEST schrieb Cyril Hrubis:
> 
> I guess that it would be cleaner to keep the single request, but define
> the s_tio as a void * here.
> 
> That way we can add test on a separate lines:
> 
> 	{&bfd, TCGETA, &termio, EBADF},
> 	{&bfd, TCGETS, &termios, EBADF},
> 	...
> 

But we have currently 4 tests that are all executed via both termio and 
termios. To keep this kind of coverage we would need to duplicate all of those 
lines. That would be 4 new test lines in total. Is that what you're 
suggesting? I'm just asking twice because I'm not sure whether it is better 
(but don't have a strong opinion).

By the way, how would I submit an amendment here? Just submit the amended 
commit again in the same way (I used `git send-email --
to=ltp@lists.linux.it`)?

And how is this merged? I saw that in another case patchwork was used? How 
does that come into play?




More information about the ltp mailing list