[LTP] [PATCH v2] kernel/device-drivers/zram/zram01.sh : don't fill from /dev/zero

Ian Wienand iwienand@redhat.com
Thu Sep 14 13:04:32 CEST 2023


On Thu, Sep 14, 2023 at 08:37:46AM +0100, Richard Palethorpe wrote:
> We don't want to remove coverage of ZRAM_SAME! A bug in ZRAM_SAME is a
> potential expoit or data-corruption.
>
> If you want to change the test you have to show where ZRAM_SAME is being
> covered instead.

The patch v2 has always had the comment and intent

+	# To make sure we are actually testing both the same-page and
+	# compression paths, we first pad with zeros but then fill
+	# with a compressible series of alternatiting 0x00 and 0xFF.
+	# This should assure we stress the compression path and can
+	# calculate the compression level reliabily.

I believe this tests both paths, and in a more rigorous manner than the
extant test.

-i



More information about the ltp mailing list